refactor: replace lint/fmt with unified vp check#135
Merged
Conversation
- Replace separate lint, fmt, fmt:check scripts with unified check/check:fix - Update CI to use single 'vp run check' step instead of separate fmt:check + lint - Update ready script to use check instead of fmt + lint - Upgrade vite-plus to 0.0.0-g61d318d2.20260227-0939 - Fix lint errors caught by new rules: - Wrap SidebarContext value in useMemo to prevent unnecessary rerenders - Use entry.name instead of array index for Cell keys in BundleSizeChart
fengmk2
force-pushed
the
refactor/vp-check
branch
from
0b15158 to
fd569a2
Compare
- Add husky and lint-staged as devDependencies (catalog mode) - Pre-commit hook runs 'vp check --fix' on staged files - Covers all file types via wildcard glob
fengmk2
force-pushed
the
refactor/vp-check
branch
from
fd569a2 to
5ccd1d5
Compare
fengmk2
added a commit
that referenced
this pull request
Feb 28, 2026
The deploy workflow used `setup-node-pnpm` which doesn't provide the `vite`/`vp` binary, causing `vite: not found` on the `pnpm build` step after #135. Fix: switch to `setup-vp` (matching ci.yml) and use `vp run @vibe/dashboard#build` directly. Fixes https://github.com/voidzero-dev/vibe-dashboard/actions/runs/22525169259/job/65256003700
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Following the pattern from voidzero-dev/setup-vp@9937ebf, replace separate lint/fmt scripts with unified
vp check.Changes
lint,fmt,fmt:checkscripts withcheck/check:fixreadyscript:vite run check && vite run test && vite run buildfmt:check+lintsteps into singlecheckstep0.0.0-ffb4d08ato0.0.0-g61d318d2.20260227-0939Lint fixes
New rules in the updated vite-plus caught two issues:
jsx-no-constructed-context-values: Wrap SidebarContext value inuseMemo()no-array-index-key: Useentry.nameinstead of array index for<Cell>keys in BundleSizeChartVerification
vp checkpasses (0 warnings, 0 errors)vp run ready— check + test + build all pass locally